Re: [PATCH] drm/i915: Don't mix inline functions with declarations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2017-09-26 at 14:37 +0000, Michal Wajdeczko wrote:
> We group function forward declarations by file. There is no
> reason to mix these declarations with our unline functions.

I'd rather like to avoid these megaheaders completely, so that
intel_uc.h would be a base header with common structs and stuff and
intel_guc.h and intel_huc.h introduce the functions and stuff which is
then implemented by their respective ".c" files.

The files are still relatively easy, so the earlier it's done, the less
pain there should be.

Then, when the megaheader is broken, the functions should be in natural
order, regardless of being inline or not (that's a volatile thing, and
may change between kernel versions).

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux