On Tue, 26 Sep 2017, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Thu, Sep 21, 2017 at 06:27:28AM -0700, Rodrigo Vivi wrote: >> On Thu, Sep 21, 2017 at 11:12:52AM +0000, Jani Nikula wrote: >> > On Wed, 20 Sep 2017, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: >> > > It seems Patchwork or SMTP servers are messing some patches >> > > and changing the original git's author name on git per "Last, First". >> > > So we end up with a mismatch were signed-off uses one name format >> > > and author is using another format. >> > > >> > > So, let's check for email addresses instead. >> > > >> > > v2: Avoid useles warning and only check for email. >> > > >> > > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> >> > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> >> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> >> > >> > Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> >> pushed, thanks. > > Yeah except this breaks funny people like me who use different mails for > stuff. My idea with fixing this was that we parse the mail name and check > for both "Last, First" and "First Last" to work around the outlook crap. > > I really don't want to send mail from @intel.com to anywhere near public > stuff. Ok, I'm fine with reverting, and finding another way. BR, Jani. > -Daniel > >> >> > >> > > --- >> > > dim | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > diff --git a/dim b/dim >> > > index dbaeb1ec944d..a63000fb67a8 100755 >> > > --- a/dim >> > > +++ b/dim >> > > @@ -689,7 +689,7 @@ function checkpatch_commit_push >> > > sha1=$1 >> > > >> > > # use real names for people with many different email addresses >> > > - author=$(git show -s $sha1 --format="format:%an") >> > > + author=$(git show -s $sha1 --format="format:%ae") >> > > committer=$(git show -s $sha1 --format="format:%cn") >> > > >> > > # check for author sign-off >> > >> > -- >> > Jani Nikula, Intel Open Source Technology Center >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
