On Tue, Sep 26, 2017 at 01:32:52PM +0530, Uma Shankar wrote: > This patch series adds properties for plane color features. It adds > properties for degamma used to linearize data, CSC used for gamut > conversion, and gamma used to again non-linearize data as per panel > supported color space. These can be utilize by user space to convert > planes from one format to another, one color space to another etc. > > Usersapce can take smart blending decisions and utilize these hardware > supported plane color features to get accurate color profile. The same > can help in consistent color quality from source to panel taking > advantage of advanced color features in hardware. > > These patches just add the property interfaces and enable helper functions. > Based on community feedabck on this one, we can build up and add hardware > specific implementation on top of this series. > > Note: This is just to get a design feedback whether these interfaces look ok. > Once, designed is agreed will re-send the series with a hardware specific > implementation along with IGT tests for plane color. What's missing from this is the property documentation for the userspace abi, like we have for the pipe color manager stuff: https://dri.freedesktop.org/docs/drm/gpu/drm-kms.html#color-management-properties Otherwise looks like a reasonable series, but the real challenges here is properly enabling this in a HDR (or at least color space) aware compositor. -Daniel > > Uma Shankar (6): > drm: Add Plane Degamma properties > drm: Add Plane CTM property > drm: Add Plane Gamma properties > drm: Define helper function for plane color enabling > drm: Define helper to set legacy gamma table size > drm/i915: Enable plane color features > > drivers/gpu/drm/drm_atomic.c | 29 ++++++++++++++++++++ > drivers/gpu/drm/drm_color_mgmt.c | 41 +++++++++++++++++++++++++++++ > drivers/gpu/drm/drm_mode_config.c | 35 +++++++++++++++++++++++++ > drivers/gpu/drm/drm_plane.c | 48 ++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/i915/i915_drv.h | 8 ++++++ > drivers/gpu/drm/i915/intel_color.c | 14 ++++++++++ > drivers/gpu/drm/i915/intel_display.c | 4 +++ > drivers/gpu/drm/i915/intel_drv.h | 9 +++++++ > drivers/gpu/drm/i915/intel_sprite.c | 4 +++ > include/drm/drm_color_mgmt.h | 8 ++++++ > include/drm/drm_mode_config.h | 28 ++++++++++++++++++++ > include/drm/drm_plane.h | 31 ++++++++++++++++++++++ > 12 files changed, 259 insertions(+) > > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
