>-----Original Message----- >From: Lankhorst, Maarten >Sent: Tuesday, September 26, 2017 3:45 PM >To: Shankar, Uma <uma.shankar@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; >dri-devel@xxxxxxxxxxxxxxxxxxxxx >Cc: Syrjala, Ville <ville.syrjala@xxxxxxxxx> >Subject: Re: [RFC v1 5/6] drm: Define helper to set legacy gamma table size > >Shankar, Uma schreef op di 26-09-2017 om 15:41 [+0530]: >> > -----Original Message----- >> > From: dri-devel [mailto:dri-devel-bounces@xxxxxxxxxxxxxxxxxxxxx] On >> > Behalf Of Lankhorst, Maarten >> > Sent: Tuesday, September 26, 2017 3:36 PM >> > To: Shankar, Uma <uma.shankar@xxxxxxxxx>; intel-gfx@lists.freedeskt >> > op.org; dri-devel@xxxxxxxxxxxxxxxxxxxxx >> > Cc: Syrjala, Ville <ville.syrjala@xxxxxxxxx> >> > Subject: Re: [RFC v1 5/6] drm: Define helper to set legacy gamma >> > table size >> > >> > Hey, >> > >> > Uma Shankar schreef op di 26-09-2017 om 13:32 [+0530]: >> > > Define a helper function to set legacy gamma table size for >> > > planes. >> > > >> > > Signed-off-by: Uma Shankar <uma.shankar@xxxxxxxxx> >> > > --- >> > > drivers/gpu/drm/drm_color_mgmt.c | 41 >> > > ++++++++++++++++++++++++++++++++++++++ >> > > include/drm/drm_color_mgmt.h | 3 +++ >> > > include/drm/drm_plane.h | 4 ++++ >> > > 3 files changed, 48 insertions(+) >> > >> > Is this needed? I'm not aware of legacy tables for planes. >> >> I was not getting very concrete info on this. So kept it as per pipe >> gamma implementation. >> I will try to get some more info and drop this in case it's not >> required. >> > >It's not, legacy gamma would only be used in drm_mode_gamma_get_ioctl, >which if you look at it only works for a crtc. :) > Yeah I thought that it was just added for crtc, and implementation for plane was not done. Was not sure if it can also be extended for plane. Will drop this change. Thanks for clarifying. Regards, Uma Shankar >~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
