Re: [PATCH i-g-t 2/2] igt_core: Rework igt_system()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 25, 2017 at 11:33:51AM +0300, Abdiel Janulgue wrote:
> 
> 
> On 09/21/2017 03:52 PM, Petri Latvala wrote:
> > Instead of redirecting output to pipes and forking, redirect after
> > forking to avoid having to carefully unredirect before logging
> > anything.
> > 
> > igt@tools_test@sysfs_l3_parity had a racy condition where it prints
> > the output of intel_l3_parity prepended by [cmd], but that ended up
> > being printed again prepended by [cmd] because output was redirected,
> > causing outputs to appear multiple times. This patch fixes that.
> > 
> > CC: Abdiel Janulgue <abdiel.janulgue@xxxxxxxxxxxxxxx>
> > Signed-off-by: Petri Latvala <petri.latvala@xxxxxxxxx>
> 
> Thanks for fixing this. Series is
> Reviewed-by: Abdiel Janulgue <abdiel.janulgue@xxxxxxxxxxxxxxx>

And pushed, thanks for the review.

The CI results were confirmed known noise.



-- 
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux