Re: [igt v2] igt/kms_psr_sink_crc: Fix the bug in psr_drrs subtest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

I'll merge this and DK's one you reviewed as soon as I recharge my laptop! :)

> On Sep 21, 2017, at 5:19 PM, Sripada, Radhakrishna <radhakrishna.sripada@xxxxxxxxx> wrote:
> 
> The substring to be matched is "DRRS Supported: Yes" and not
> "DRRS Support: No". The kernel prints the DRRS status for all active
> CRTC's. Matching for No support gives a false positive when multiple
> CRTC's are active.
> 
> Fixes: 33355210a43e (igt/kms_psr_sink_crc: Add psr_drrs subtest)
> Cc: C. Ramalingam <ramalingam.c@xxxxxxxxx>
> Cc: Lohith BS <lohith.bs@xxxxxxxxx>
> Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx>
> ---
> tests/kms_psr_sink_crc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> index 1c25f2c81a34..f023b12c0131 100644
> --- a/tests/kms_psr_sink_crc.c
> +++ b/tests/kms_psr_sink_crc.c
> @@ -290,7 +290,7 @@ static bool drrs_disabled(data_t *data)
> 
>    igt_debugfs_read(data->drm_fd, "i915_drrs_status", buf);
> 
> -    return strstr(buf, "DRRS Support: No\n");
> +    return !strstr(buf, "DRRS Supported: Yes\n");
> }
> 
> static void run_test(data_t *data)
> -- 
> 2.9.3
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux