Re: [PATCH 00/14] GuC code restructuring and fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/20/2017 1:45 AM, Michal Wajdeczko wrote:
On Tue, 19 Sep 2017 19:27:37 +0200, Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx> wrote:

This series is based on reviews from https://patchwork.freedesktop.org/series/30502/.

Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
Cc: Michał Winiarski <michal.winiarski@xxxxxxxxx>

Sagar Arun Kamble (14):
  drm/i915/guc: Pass intel_guc struct as parameter to
    intel_guc_wopcm_size
  drm/i915: Create intel_uc_init_mmio to initialize MMIO interface prior
    to uc init
  drm/i915/guc: Create intel_guc_init_early
  drm/i915: Create intel_guc.h, intel_huc.h and intel_uc_common.h
  drm/i915/guc: Move GuC specific functionality from intel_uc.c to
    intel_guc.c
  drm/i915: Create uc runtime and system suspend/resume helpers
  drm/i915/guc: Update prototype/name of GuC suspend/resume fns and move
    to intel_guc.c
  drm/i915/guc: Update GuC ggtt.invalidate/interrupts/communication
    across RPM suspend/resume
  drm/i915/guc: Update suspend functionality in intel_uc_suspend path
  drm/i915/guc: Reuse GuC suspend functionality in reset path
  drm/i915/guc: Fix GuC cleanup in unload path
  drm/i915/guc: Remove i915_guc_log_unregister
  drm/i915/guc: Enable default/critical logging in GuC by default from
    GuC v9
  drm/i915: Reorganize HuC authentication


Refactoring whole guc code in one series can be very long task.
By adding more and more fixes here you're preventing merge of the
most important patch.

Michal
Will float the fixes first now and then will restart the restructuring.
Current patches are smaller logical changes w.r.t restructuring compared to my earlier series so I thought
it would be nice to get those in along with the fixes. Thanks Michal.
 drivers/gpu/drm/i915/Makefile |   1 +
 drivers/gpu/drm/i915/i915_drv.c            |  28 +++-
 drivers/gpu/drm/i915/i915_gem.c            |   9 +-
 drivers/gpu/drm/i915/i915_guc_submission.c |  54 +------
drivers/gpu/drm/i915/intel_guc.c | 246 +++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_guc.h           | 185 ++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_guc_fwif.h      |   4 +-
 drivers/gpu/drm/i915/intel_guc_loader.c    |   3 +-
 drivers/gpu/drm/i915/intel_guc_log.c       |  25 ++-
 drivers/gpu/drm/i915/intel_huc.c           |  22 +--
 drivers/gpu/drm/i915/intel_huc.h           |  41 +++++
 drivers/gpu/drm/i915/intel_uc.c            | 165 ++++++-------------
drivers/gpu/drm/i915/intel_uc.h | 205 ++----------------------
 drivers/gpu/drm/i915/intel_uc_common.h     |  67 ++++++++
 14 files changed, 653 insertions(+), 402 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/intel_guc.c
 create mode 100644 drivers/gpu/drm/i915/intel_guc.h
 create mode 100644 drivers/gpu/drm/i915/intel_huc.h
 create mode 100644 drivers/gpu/drm/i915/intel_uc_common.h

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux