On Mon, 18 Sep 2017, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > To make it easier to debug things let's dump the output types bitmask in > the crtc state dump. And to make life that much better, let's pretty > print it as a a human reaadable string as well. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_display.c | 50 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 8599e425abb1..192b07a92e76 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -10683,6 +10683,53 @@ intel_dump_m_n_config(struct intel_crtc_state *pipe_config, char *id, > m_n->link_m, m_n->link_n, m_n->tu); > } > > +#define OUTPUT_TYPE(x) [INTEL_OUTPUT_ ## x] = #x > + > +static const char * const output_type_str[] = { > + OUTPUT_TYPE(UNUSED), > + OUTPUT_TYPE(ANALOG), > + OUTPUT_TYPE(DVO), > + OUTPUT_TYPE(SDVO), > + OUTPUT_TYPE(LVDS), > + OUTPUT_TYPE(TVOUT), > + OUTPUT_TYPE(HDMI), > + OUTPUT_TYPE(DP), > + OUTPUT_TYPE(EDP), > + OUTPUT_TYPE(DSI), > + OUTPUT_TYPE(UNKNOWN), > + OUTPUT_TYPE(DP_MST), > +}; > + #undef OUTPUT_TYPE > +static const char *output_types_str(unsigned int output_types) > +{ > + static char buf[64]; > + size_t len = sizeof(buf); > + char *str = buf; > + int i; > + > + str[0] = '\0'; > + > + for (i = 0; i < ARRAY_SIZE(output_type_str); i++) { > + int r; > + > + if ((output_types & BIT(i)) == 0) > + continue; > + > + r = snprintf(str, len, "%s%s", > + str != buf ? "," : "", output_type_str[i]); > + if (r >= len) > + break; > + str += r; > + len -= r; > + > + output_types &= ~BIT(i); > + } > + > + WARN_ON_ONCE(output_types != 0); > + > + return buf; > +} > + > static void intel_dump_pipe_config(struct intel_crtc *crtc, > struct intel_crtc_state *pipe_config, > const char *context) > @@ -10696,6 +10743,9 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, > > DRM_DEBUG_KMS("[CRTC:%d:%s]%s\n", > crtc->base.base.id, crtc->base.name, context); > + DRM_DEBUG_KMS("output_types: %s (0x%x)\n", > + output_types_str(pipe_config->output_types), > + pipe_config->output_types); > > DRM_DEBUG_KMS("cpu_transcoder: %s, pipe bpp: %i, dithering: %i\n", > transcoder_name(pipe_config->cpu_transcoder), -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx