On Fri, 15 Sep 2017, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > Quoting Michal Wajdeczko (2017-09-14 16:08:03) >> We're always specifying description of each module param in >> separate macro. Let's combine description into our main macro. >> Started with Coccinelle, followed by minor cleanup. >> >> @match1@ >> declarer name MODULE_PARM_DESC; >> identifier n; >> constant c; >> @@ >> ( >> - MODULE_PARM_DESC(n, c); >> ) >> >> @fix1 depends on match1@ >> declarer name i915_param_named; >> declarer name i915_param_named_unsafe; >> identifier match1.n; >> constant match1.c; >> @@ >> ( >> i915_param_named(n, ... >> + , c >> ); >> | >> i915_param_named_unsafe(n, ... >> + , c >> ); >> ) >> >> Suggested-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> >> Cc: Jani Nikula <jani.nikula@xxxxxxxxx> >> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Pushed patches 1-3, undecided for the rest. Thanks for the patches and review. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx