Re: [PATCH] drm/i915: Remove uused 'in_vbl' from i915_get_crtc_scanoutpos()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 14, 2017 at 05:42:13PM +0100, Chris Wilson wrote:
> Commit 1bf6ad622b9b ("drm/vblank: drop the mode argument from
> drm_calc_vbltimestamp_from_scanoutpos") removed the use of in_vbl, but
> did not remove the local variable. Do so now.
> 
> Fixes: 1bf6ad622b9b ("drm/vblank: drop the mode argument from drm_calc_vbltimestamp_from_scanoutpos")
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>

Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/i915_irq.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 91a2c5dbf2da..066a6b355cf1 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -839,7 +839,6 @@ static bool i915_get_crtc_scanoutpos(struct drm_device *dev, unsigned int pipe,
>  								pipe);
>  	int position;
>  	int vbl_start, vbl_end, hsync_start, htotal, vtotal;
> -	bool in_vbl = true;
>  	unsigned long irqflags;
>  
>  	if (WARN_ON(!mode->crtc_clock)) {
> @@ -922,8 +921,6 @@ static bool i915_get_crtc_scanoutpos(struct drm_device *dev, unsigned int pipe,
>  
>  	spin_unlock_irqrestore(&dev_priv->uncore.lock, irqflags);
>  
> -	in_vbl = position >= vbl_start && position < vbl_end;
> -
>  	/*
>  	 * While in vblank, position will be negative
>  	 * counting up towards 0 at vbl_end. And outside
> -- 
> 2.14.1

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux