Re: [PATCH i-g-t] lib/igt_kmod: Allow specifying libkmod config via environment variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2017-09-13 at 11:37 +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2017-09-12 16:51:40)
> > Quoting Joonas Lahtinen (2017-09-12 16:44:10)
> > > Allow specifying the kernel module configuration via environment
> > > variables. This allows enumerating the subtests of the kselftest
> > > wrappers from sysroot directory.
> > > 
> > > IGT_KMOD_CONFIG_PATHS="" \
> > > IGT_KMOD_DIRNAME="/path/to/sysroot/lib/modules/X.Y.Z" \
> > >         tests/drm_mm --list-subtests
> > 
> > Just one quibble, but shouldn't it be PATH?  E.g.
> 
> On reflection, they match the libkmod names, so who am I to judge?
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Yeah, I was considering IGT_MODULE_PATH and IGT_MODULE_CONFIG_PATH, but
that would have indicated they might be used in other ways too,
strictly sticking to KMOD convention seemed would cause least
confusion.

This is now pushed, thanks for the review.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux