On Fri, Sep 08, 2017 at 09:48:17AM -0700, Belgaumkar, Vinay wrote:
[SNIP]
> > > >
> > > > + /* Checks if we achieve boost using gem_wait */
> > >
> > > We should mention this is doing gem_wait on a spinning batch, hence the
> > > boost.
> > I think that additional information is not needed here. I got 2 reasons:
> > - we assume that subtest comment will be oneliner
> > - do we need such details here?
>
> This current form gives the idea that we can get turbo boost by simply doing
> a gem_wait, which is incorrect. We either say "Checks if we can achieve
> boost" or then give the complete info - "Checks if we can achieve boost
> using gem_wait on a spinning batch". Either ways, it is still single line.
Yes, the request needs to be incomplete to grant boost.
No, stating that we're granting boost on spinning batches is confusing because
of terminology overload (spinbatch is a specific type of GPU load that we're
using).
-Michał
>
> >
> > Thanks,
> > Kasia
> > >
> > > Other than this and the above comment, LGTM.
> > >
> > > Acked-by: Vinay Belgaumkar <vinay.belgaumkar@xxxxxxxxx>
> > >
> > >
> > > > igt_subtest("waitboost")
> > > > waitboost(drm_fd, false);
> > > >
> > > > + /* Test boost frequency after GPU reset */
> > > > igt_subtest("reset") {
> > > > igt_hang_t hang = igt_allow_hang(drm_fd, 0, 0);
> > > > waitboost(drm_fd, true);
> > > >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
