No problem! I will commit a patch for CNP later.
On Tue, 12 Sep 2017, "Lee, Shawn C" <shawn.c.lee@xxxxxxxxx> wrote:
> Min brightness value from vbt was missing for BXT platform.
> This setting have to refer backlight ic spec to restrict min backlight
> output. Without this restriction, driver would allow to configure
> lower brightness value and violate backlight ic requirement.
>
> Fixes: 0fb890c01349 ("drm/i915/bxt: BLC implementation")
> Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
> Cc: Cooper Chiou <cooper.chiou@xxxxxxxxx>
> Cc: Gary C Wang <gary.c.wang@xxxxxxxxx>
> Signed-off-by: Shawn Lee <shawn.c.lee@xxxxxxxxx>
Pushed to drm-intel-next-queued, thanks for the patch.
Care to send a similar patch for cnp_setup_backlight, please?
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_panel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_panel.c
> b/drivers/gpu/drm/i915/intel_panel.c
> index a17b1de7d7e0..d4dd248ac9a8 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -1699,6 +1699,8 @@ bxt_setup_backlight(struct intel_connector *connector, enum pipe unused)
> if (!panel->backlight.max)
> return -ENODEV;
>
> + panel->backlight.min = get_backlight_min_vbt(connector);
> +
> val = bxt_get_backlight(connector);
> val = intel_panel_compute_brightness(connector, val);
> panel->backlight.level = clamp(val, panel->backlight.min,
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
