Thanks! Learned. :) -----Original Message----- From: Joonas Lahtinen [mailto:joonas.lahtinen@xxxxxxxxxxxxxxx] Sent: Friday, September 8, 2017 2:54 PM To: Wang, Zhi A <zhi.a.wang@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx Cc: chris@xxxxxxxxxxxxxxxxxx; zhenyuw@xxxxxxxxxxxxxxx; Widawsky, Benjamin <benjamin.widawsky@xxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx> Subject: Re: [PATCH v8 1/5] drm/i915: Factor out setup_private_pat() On Fri, 2017-09-08 at 17:05 +0800, Zhi Wang wrote: > Factor out setup_private_pat() for introducing the following patches. > > Cc: Ben Widawsky <benjamin.widawsky@xxxxxxxxx> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> v7 > Signed-off-by: Zhi Wang <zhi.a.wang@xxxxxxxxx> Keep this in chronological order when you add things, so R-b after S-o- b. Only add the version after R-b *if* the review might have been invalidated due to some changes, in this case there are no changes and no changelog, so you can keep the R-b. If there was substantial enough changes, changelog would be added and #v7 added to previous reviews to indicate they do not apply to latest changes. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
