Re: [PATCH i-g-t] lib: Assert when gem is dead in igt_require_gem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Daniel Vetter (2017-09-08 07:38:24)
> The function is perhaps a bit renamed, but if a previous tests failed
> so badly it left the gpu wrecked, then we should fail, not skip.
> 
> Testcases shouldn't ever randomly skip at least, since that just
> indicates whether the feature is there or not. Pass/fail is for
> whether it's working or not.

Not quite, now you are randomly failing a test even before it is testing
anything. Should we fail every test just because we can't open an fd?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux