On Wed, Sep 06, 2017 at 05:15:49PM -0700, Oscar Mateo wrote: > Afaict, GEN9_GAMT_ECO_REG_RW_IA does not live in the context, so writing > it on every context creation is overkill (and wrong). > > v2: Missing end parenthesis Though there was a discussion whether this belongs in init_workarounds, or init_clock_gating - I do believe that moving things around and/or renaming things is something that should be done in a separate patch. I compared modified registers with the spec. It all checks out. With the missing end parenthesis added (you're still missing some in a different patch ;) ), the whole series is: Reviewed-by: Michał Winiarski <michal.winiarski@xxxxxxxxx> -Michał > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_engine_cs.c | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-) _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
