On Tue, Sep 5, 2017 at 11:08 PM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > Quoting Daniel Vetter (2017-09-05 17:19:45) >> In meson I want to just set this everywhere (no reason not to), and >> doing so will allow us to clean up a few things. > > If we are keeping config.h in meson, why move -D_GNU_SOURCE to the > commandline, surely the fix is that those files not including config.h > should? Today it's a missing _GNU_SOURCE, tomorrow it could be any of the > little config details. Ime _GNU_SOURCE tends to fail somewhat silent, but if you forget to include config.h for a HAVE_FOO_LIB, you'll noticed pretty fast. That's more or less my thinking, but I guess we could force-include config.h everywhere by default too. Not sure that's good, since we imo overuse all those little optional deps way too much. And there's a _lot_ of places which don't include config.h. Pretty much all the test for example. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
