The revert patch solved the issue
*ERROR* Video mode command 0x00000041 send failed.
on my setup with APL+MIPI/DSI single link combo.
Tested-by: Mika Kahola <mika.kahola@xxxxxxxxx>
On Tue, 2017-09-05 at 15:14 +0530, Vidya Srinivas wrote:
> From: Uma Shankar <uma.shankar@xxxxxxxxx>
>
> This reverts commit bbdf0b2ff32aa75c7bd167569130e9391d2e6282.
>
> Disable device ready before shutdown command was added previously to
> avoid a
> split screen issue seen on dual link DSI panels. As of now, dual link
> is not
> supported and will need some rework in the upstream code. For single
> link DSI
> panels, the change is not required. This will cause failure in
> sending SHUTDOWN
> packet during disable. Hence reverting the change. Will handle the
> change
> as part of dual link enabling in upstream.
>
> Signed-off-by: Uma Shankar <uma.shankar@xxxxxxxxx>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c
> b/drivers/gpu/drm/i915/intel_dsi.c
> index 2a0f5d3..fc25d7d 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -892,8 +892,6 @@ static void intel_dsi_disable(struct
> intel_encoder *encoder,
> const struct intel_crtc_state
> *old_crtc_state,
> const struct drm_connector_state
> *old_conn_state)
> {
> - struct drm_device *dev = encoder->base.dev;
> - struct drm_i915_private *dev_priv = dev->dev_private;
> struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder-
> >base);
> enum port port;
>
> @@ -903,15 +901,6 @@ static void intel_dsi_disable(struct
> intel_encoder *encoder,
> intel_panel_disable_backlight(old_conn_state);
>
> /*
> - * Disable Device ready before the port shutdown in order
> - * to avoid split screen
> - */
> - if (IS_BROXTON(dev_priv)) {
> - for_each_dsi_port(port, intel_dsi->ports)
> - I915_WRITE(MIPI_DEVICE_READY(port), 0);
> - }
> -
> - /*
> * According to the spec we should send SHUTDOWN before
> * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing
> * has shown that the v3 sequence works for v2 VBTs too
--
Mika Kahola - Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
