Re: [PATCH 3/3] drm/i915: Fix enum pipe vs. enum transcoder for the PCH transcoder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting ville.syrjala@xxxxxxxxxxxxxxx (2017-09-01 15:31:23)
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> Use enum pipe for PCH transcoders also in the FIFO underrun code.
> 
> Fixes the following new sparse warnings:
> intel_fifo_underrun.c:340:49: warning: mixing different enum types
> intel_fifo_underrun.c:340:49:     int enum pipe  versus
> intel_fifo_underrun.c:340:49:     int enum transcoder
> intel_fifo_underrun.c:344:49: warning: mixing different enum types
> intel_fifo_underrun.c:344:49:     int enum pipe  versus
> intel_fifo_underrun.c:344:49:     int enum transcoder
> intel_fifo_underrun.c:397:57: warning: mixing different enum types
> intel_fifo_underrun.c:397:57:     int enum pipe  versus
> intel_fifo_underrun.c:397:57:     int enum transcoder
> intel_fifo_underrun.c:398:17: warning: mixing different enum types
> intel_fifo_underrun.c:398:17:     int enum pipe  versus
> intel_fifo_underrun.c:398:17:     int enum transcoder
> 
> Cc: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> Fixes: a21960339c8c ("drm/i915: Consistently use enum pipe for PCH transcoders")
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

C types are consistent, so
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

I have not checked if the semantics are correct...
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux