Do you mean I still keep I915_WRITE(xxxxx) in xxxx_setup_private_pat() like before? Then changed them in a new patch? Thanks, Zhi. -----Original Message----- From: Joonas Lahtinen [mailto:joonas.lahtinen@xxxxxxxxxxxxxxx] Sent: Thursday, August 31, 2017 11:26 AM To: Wang, Zhi A <zhi.a.wang@xxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; zhenyuw@xxxxxxxxxxxxxxx; intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx; chris@xxxxxxxxxxxxxxxxxx; Widawsky, Benjamin <benjamin.widawsky@xxxxxxxxx> Subject: Re: [RFCv6 2/2] drm/i915: Introduce private PAT management On Thu, 2017-08-31 at 12:49 +0800, Zhi Wang wrote: > Hi Vivi: > Thanks for the reply! The register are written in > ppat->update_hw() now. Could we do like I already asked and not simultaneously change the code organization and register values? Just have this patch write exactly the same values to all registers than before, then a patch after this which removes the supposedly unused variables from kernel. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx