On Tue, 29 Aug 2017, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Mon, Aug 28, 2017 at 03:19:52PM +0300, Jani Nikula wrote: >> There's little point in duplicating the efforts of describing the same >> data in two places. This series lets us use the verbatim copy of the >> intel_vbt_defs.h from kernel. Going forward, we should add the changes >> in kernel first, then copy the header over to igt. >> >> If we need local tweaks, we can still have them in intel_bios.h, and >> indeed we'll still have some after this series. > > I assume the end result matches what we now have in the kernel. Might be > good practice to reference the sha1 of the kernel commit (needs to be a > stable sha1, not drm-tip ofc) when resyncing in the future. On the series: > > Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx> Pushed, with the kernel commit reference added. There'd be plenty to tweak and fix here, but the main goal of reducing duplication was reached, so that'll do for now. BR, Jani. >> >> BR, >> Jani. >> >> Jani Nikula (10): >> tools/intel_lid: use local register definition >> tools/intel_vbt_decode: remove unused definitions from intel_bios.h >> tools/intel_vbt_decode: clean up struct lvds_dvo_timing >> tools/intel_vbt_decode: start migrating to kernel intel_vbt_defs.h >> tools/intel_vbt_decode: migrate timing dumping to kernel struct >> tools/intel_vbt_decode: migrate child device dumping to kernel struct >> tools/intel_vbt_decode: migrate psr dumping to kernel struct >> tools/intel_vbt_decode: migrate edp dumping to kernel struct >> tools/intel_vbt_decode: migrate child device type bits decoding to >> kernel defs >> tools/intel_vbt_defs: migrate backlight dumping to kernel struct >> >> tools/intel_bios.h | 760 +-------------------------------------- >> tools/intel_lid.c | 5 +- >> tools/intel_vbt_decode.c | 180 +++++----- >> tools/intel_vbt_defs.h | 897 +++++++++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 996 insertions(+), 846 deletions(-) >> create mode 100644 tools/intel_vbt_defs.h >> >> -- >> 2.11.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
