In my view, this is a valid check. Reviewed-by: Mika Kahola <mika.kahola@xxxxxxxxx> On Tue, 2017-08-29 at 13:32 +0300, Marta Lofstedt wrote: > Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_para > ms. > This leads to segfault on machines where the subtest should be > skipped. > > Signed-off-by: Marta Lofstedt <marta.lofstedt@xxxxxxxxx> > --- > tests/kms_atomic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c > index d77a526f..042a7c26 100644 > --- a/tests/kms_atomic.c > +++ b/tests/kms_atomic.c > @@ -1596,6 +1596,7 @@ igt_main > struct kms_atomic_connector_state *conn = > find_connector(scratch, crtc); > > + igt_require(crtc); > igt_require(plane); > igt_require(conn); > atomic_invalid_params(crtc, plane, conn); -- Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
