I can no longer reproduce the flip/flopping "FBC disabled" on the kms_frontbuffer_tracking tests. Instead I hit: WARNING: CPU: 2 PID: 25732 at drivers/gpu/drm/i915/intel_fbc.c:1173 WARNING: CPU: 2 PID: 25732 at drivers/gpu/drm/i915/intel_fbc.c:1141 /Marta > -----Original Message----- > From: Lofstedt, Marta > Sent: Friday, August 25, 2017 4:34 PM > To: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Zanoni, Paulo R <paulo.r.zanoni@xxxxxxxxx> > Subject: RE: [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: > increase FBC wait timeout to 5s > > +paulo > > > -----Original Message----- > > From: Chris Wilson [mailto:chris@xxxxxxxxxxxxxxxxxx] > > Sent: Friday, August 25, 2017 4:12 PM > > To: Lofstedt, Marta <marta.lofstedt@xxxxxxxxx>; intel- > > gfx@xxxxxxxxxxxxxxxxxxxxx > > Subject: RE: [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: > > increase FBC wait timeout to 5s > > > > Quoting Lofstedt, Marta (2017-08-25 13:50:16) > > > > > > > > > > -----Original Message----- > > > > From: Lofstedt, Marta > > > > Sent: Friday, August 25, 2017 2:54 PM > > > > To: 'Chris Wilson' <chris@xxxxxxxxxxxxxxxxxx>; > > > > intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > > > Subject: RE: [PATCH i-g-t v2] > tests/kms_frontbuffer_tracking: > > > > increase FBC wait timeout to 5s > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Chris Wilson [mailto:chris@xxxxxxxxxxxxxxxxxx] > > > > > Sent: Friday, August 25, 2017 1:47 PM > > > > > To: Lofstedt, Marta <marta.lofstedt@xxxxxxxxx>; intel- > > > > > gfx@xxxxxxxxxxxxxxxxxxxxx > > > > > Subject: Re: [PATCH i-g-t v2] > > tests/kms_frontbuffer_tracking: > > > > > increase FBC wait timeout to 5s > > > > > > > > > > Quoting Marta Lofstedt (2017-08-25 11:40:29) > > > > > > From: "Lofstedt, Marta" <marta.lofstedt@xxxxxxxxx> > > > > > > > > > > > > The subtests: igt@kms_frontbuffer_tracking@fbc-*draw* > > > > > > has non-consistent results, pending between fail and pass. > > > > > > The fails are always due to "FBC disabled". > > > > > > With this increase in timeout the flip-flop behavior is no > > > > > > longer reproducible. > > > > > > > > > > > > This is a partial revert of: > > > > > > 64590c7b768dc8d8dd962f812d5ff5a39e7e8b54, > > > > > > where the timeout was decreased from 5s to 2s. > > > > > > After investigating the timeout needed, the conclusion is that > > > > > > the longer timeout is only needed when the test swaps between > > > > > > some specific draw domains, typically blt vs. mmap_cpu. > > > > > > The objective of the FBC part of the tests is not to benchmark > > > > > > draw domain changes, it is to check that FBC was (re-)enabled. > > > > > > > > > > > > V2: Added documentation > > > > > > > > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101623 > > > > > > Signed-off-by: Marta Lofstedt <marta.lofstedt@xxxxxxxxx> > > > > > > Acked-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > > > > > --- > > > > > > tests/kms_frontbuffer_tracking.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/tests/kms_frontbuffer_tracking.c > > > > > > b/tests/kms_frontbuffer_tracking.c > > > > > > index e03524f1..2538450c 100644 > > > > > > --- a/tests/kms_frontbuffer_tracking.c > > > > > > +++ b/tests/kms_frontbuffer_tracking.c > > > > > > @@ -924,7 +924,7 @@ static bool fbc_stride_not_supported(void) > > > > > > > > > > > > static bool fbc_wait_until_enabled(void) { > > > > > > > > > > Try igt_drop_caches_set(device, DROP_RETIRE); instead of > > > > > relaxing the timeout. > > > > > -Chris > > > > > > > > OK, I will test that and do a V3 if it works! > > > > /Marta > > > > > > I did some initial testing with igt_drop_caches_set inside > > fbc_wait_until_enabled and it looks good, I will add this to my > > weekend tests to get more results. This also appear to improve the > > runtime of the tests quite a bit. So, maybe the igt_drop_caches_set > > should be placed somewhere else so it will give runtime improvements > > not only for the FBC related sub- tests. > > > > Sure, all the waits can do with the retire first, give it a common > > function and a comment for the rationale (which should pretty much the > > same as given in the changelog). Anytime we use the GPU to invalidate > > the frontbuffer tracking, we have to wait for a retire to do the flush. > > Retirement is lazy, and is normally driven by GPU activity but we have > > a background kworker to make sure we notice when the system becomes > > idle independent of userspace - except it's low frequency. > > -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
