On Fri, 25 Aug 2017, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Fri, Aug 25, 2017 at 05:11:22PM +0300, Jani Nikula wrote: >> Copy over some fields defined in the intel_vbt_decode tool. No >> functional changes. >> >> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> --- >> drivers/gpu/drm/i915/intel_vbt_defs.h | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h >> index 14623748b388..ea508ecc74b3 100644 >> --- a/drivers/gpu/drm/i915/intel_vbt_defs.h >> +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h >> @@ -380,7 +380,11 @@ struct child_device_config { >> } __packed; >> } __packed; >> >> - u8 capabilities; >> + u8 pipe_cap:2; >> + u8 sdvo_stall:1; > > igt has a /* 158 */ comment here. > > Otherwise it all looks to match. For the series > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Pushed the lot, thanks for the review. I took the liberty of adding the comment while applying. BR, Jani. > >> + u8 hpd_status:2; >> + u8 integrated_encoder:1; >> + u8 capabilities_reserved:2; >> u8 dvo_wiring; /* See DEVICE_WIRE_* above */ >> >> union { >> @@ -390,7 +394,8 @@ struct child_device_config { >> >> u16 extended_type; >> u8 dvo_function; >> - u8 flags2; /* 195 */ >> + u8 dp_usb_type_c:1; /* 195 */ >> + u8 flags2_reserved:7; /* 195 */ >> u8 dp_gpio_index; /* 195 */ >> u16 dp_gpio_pin_num; /* 195 */ >> u8 dp_iboost_level:4; /* 196 */ >> -- >> 2.11.0 -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx