Hi Daniel, On 25 August 2017 at 18:17, Daniel Vetter <daniel@xxxxxxxx> wrote: > Which of these do we need to cherry-pick over to -next-fixes? There's no > annotations about that. If the answer is "most" I'm leaning towards > disabling CCS for 4.14, minimal set would be ideal (and first in the patch > series). My opinion below; tl;dr is that I don't think most of them are super-critical. Ville obviously has a far stronger opinion than me on the shape of the code, so I'm fine with this series, which seems to mostly be a merge back of the delta between whatever Ville's latest branch was, and whatever the last patchset Ben sent out was. >> Ville Syrjälä (12): >> drm/i915: Treat fb->offsets[] as a raw byte offset instead of a linear >> offset This should land into -fixes. I trust Ville that it has no UABI impact, but seems like something to be very consistent on. >> drm/i915: Skip fence alignemnt check for the CCS plane Not sure if this is -fixes material really, just a cleanup? >> drm/i915: Switch over to the LLC/eLLC hotspot avoidance hash mode for >> CCS Not -fixes, performance optimisation. >> drm/i915: Add a comment exlaining CCS hsub/vsub Seems harmless to land to -fixes. >> drm/i915: Nuke a pointless unreachable() Ditto. >> drm/i915: Add the missing Y/Yf modifiers for SKL+ sprites Per my previous reply, NAK to landing at all, since DDB/WM allocation seems too broken for it to work. >> drm/i915: Clean up the sprite modifier checks Fine with this, but doesn't seem like -fixes material. >> drm/i915: Add CCS capability for sprites NAK, same reason as Y/Yf. >> drm/i915: Allow up to 32KB stride on SKL+ "sprites" Again doesn't seem like -fixes necessarily? >> drm: Fix modifiers_property kernel doc Good for -fixes. >> drm: Check that the plane supports the request format+modifier combo Good for core (not Intel) -fixes. >> drm/i915: Remove the pipe/plane ID checks from >> skl_check_ccs_aux_surface() Seems fine but probably not -fixes material; land in Intel after a merge? Cheers, Daniel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
