Re: [PATCH igt] lib/kmod: Fix error reporting for kmod load/unload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 25, 2017 at 06:28:36PM +0100, Chris Wilson wrote:
> A "return -err ? err < 0 : err" managed to slip through. So if err was
> set, we returned 0 or 1 based on sign, or 0 if err was zero.
> 
> If err is negative, we want treat it as an error, so report it back
> to the caller, all other values were a success, so convert those to 0.
> 
> This should actually be no functional change, as all errors were
> reported as 1, and everything else as 0.
> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>


Reviewed-by: Petri Latvala <petri.latvala@xxxxxxxxx>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux