On 23/08/17 15:11, Sujaritha Sundaresan wrote:
Whenever we need i915.enable_guc_submission=1, we also need enable_guc_loading=1. We also need enable_guc_loading=1 when we want to verify the HuC, which is every time we have a HuC (but all platforms with HuC have a GuC and viceversa). We don't need the user to tell when to enable the GuC loading
Drive-by comment: I'd call out more explicitly that with this patch as long as both GuC and HuC FW are on the machine they will always be loaded, which is a change to the current behavior. I'm not implying that the change is bad, but it alters timing in some scenarios (e.g. resume) and interested parties might miss it if we aren't explicit about it.
Thanks, Daniele
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxx> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@xxxxxxxxx> ---
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
