On Wed, Aug 23, 2017 at 10:14:56AM +0100, Chris Wilson wrote: > During the context-close, we should be decoupling all the vma from the > object so that upon object-closing we shouldn't see any vma from the > already closed contexts. So include a check upon closing the object that > the context is still open. > > v2: Eek, the fpriv check is required for shared objects. Double eek, BAT > passed? > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Reviewed-by: Michał Winiarski <michal.winiarski@xxxxxxxxx> You also lost: Tested-by: Marta Lofstedt <marta.lofstedt@xxxxxxxxx> On those 3 related patches. -Michał > --- > drivers/gpu/drm/i915/i915_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index b9e8e0d6e97b..3ed9fb0921e2 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -3253,11 +3253,11 @@ void i915_gem_close_object(struct drm_gem_object *gem, struct drm_file *file) > struct i915_gem_context *ctx = lut->ctx; > struct i915_vma *vma; > > + GEM_BUG_ON(ctx->file_priv == ERR_PTR(-EBADF)); > if (ctx->file_priv != fpriv) > continue; > > vma = radix_tree_delete(&ctx->handles_vma, lut->handle); > - > if (!i915_vma_is_ggtt(vma)) > i915_vma_close(vma); > > -- > 2.14.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
