[maintainer-tools PATCH 23/30] qf: SC2053 - Fix another shellcheck complain:

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



^-- SC2053: Quote the rhs of != in [[ ]] to prevent glob matching.

Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
---
 qf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qf b/qf
index 48dfe20b1693..cbe8a69e1a83 100755
--- a/qf
+++ b/qf
@@ -86,7 +86,7 @@ function repo_check # allow-detached
 
 	baseline=$(source patches/config ; echo $BASELINE)
 
-	if [[ $(git rev-parse HEAD) != $baseline ]] ; then
+	if [[ $(git rev-parse HEAD) != "$baseline" ]] ; then
 		echo Baseline commit doesn\'t match with quilt config
 		exit 7
 	fi
@@ -356,7 +356,7 @@ function qf_push
 	export_quilt_sha=$(git notes --ref=quilt show $branch | grep Quilt-Commit | cut -d ' ' -f 2)
 	quilt_sha=$(cd patches ; git rev-parse $quilt_branch)
 
-	if [[ $export_quilt_sha != $quilt_sha ]] ; then
+	if [[ $export_quilt_sha != "$quilt_sha" ]] ; then
 		echo Quilt export is out of date, aborting
 		echo $export_quilt_sha
 		echo $quilt_sha
-- 
2.13.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux