I just saw comments for the code (in first patch version)
> static void boost_freq(int fd, int *boost_freqs) {
> int64_t timeout = 1;
> - int ring = -1;
> igt_spin_t *load;
> + unsigned int engine;
>
> - load = igt_spin_batch_new(fd, ring, 0);
> -
> + /* put boost on the same engine as low load */
> + engine = I915_EXEC_RENDER;
> + if (intel_gen(lh.devid) >= 6)
> + engine = I915_EXEC_BLT;
> + load = igt_spin_batch_new(fd, engine, 0);
>Something to note is that spin-batch will also force the GPU to maximum.
So we can get rid of gem_wait in this case?
>You could set the boost freq > max freq to differentiate
What do you mean by that?
> /* Waiting will grant us a boost to maximum */
> gem_wait(fd, load->handle, &timeout);
>
> read_freqs(boost_freqs);
> dump(boost_freqs);
> + igt_assert_eq(is_in_boost(), 1);
>Will fail on older kernels.
This assert was changed in v2 to igt_assert(). Will this also fail on older kernels? If yes, why?
Thanks,
Kasia
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
