Quoting Michel Thierry (2017-08-18 17:31:38) > On 18/08/17 02:05, Chris Wilson wrote: > > During a global reset, we disable the irq. As we disable the irq, the > > hardware may be raising a GT interrupt that we then ignore, leaving it > > pending in the GTIIR. After the reset, we then re-enable the irq, > > triggering the pending interrupt. However, that interrupt was for the > > stale state from before the reset, and the contents of the CSB buffer > > are now invalid. > > > > v2: Add a comment to make it clear that the double clear is purely my > > paranoia. > > Or say I was the paranoid. > > > > > Reported-by: "Dong, Chuanxiao" <chuanxiao.dong@xxxxxxxxx> > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: "Dong, Chuanxiao" <chuanxiao.dong@xxxxxxxxx> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > Cc: Michal Winiarski <michal.winiarski@xxxxxxxxx> > > Cc: Michel Thierry <michel.thierry@xxxxxxxxx> > > Link: https://patchwork.freedesktop.org/patch/msgid/20170807121919.30165-1-chris@xxxxxxxxxxxxxxxxxx [snip] > Reviewed-by: Michel Thierry <michel.thierry@xxxxxxxxx> Marked it up with Fixes: 821ed7df6e2a ("drm/i915: Update reset path to fix incomplete requests") as though the likelihood is very low, we might as well be accurate. Thanks for the review, and many thanks to Chuanxiao for spotting the issue. Pushed. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
