On Thu, 2017-08-17 at 15:59 +0300, Mika Kahola wrote: > On Thu, 2017-07-06 at 13:54 -0700, Rodrigo Vivi wrote: > > Cannonlake uses a different swing voltage initalization > > sequence scheme that doesn't require these old functions. > > > > All other DDI, voltage swing and PLLs initialialization > > and configuration are already in place for Cannonlake. > > This patch only removes unecessary steps probably saving > > us from some useless warnings. > > > > Cc: Clint Taylor <clinton.a.taylor@xxxxxxxxx> > > Cc: Mika Kahola <mika.kahola@xxxxxxxxx> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/intel_ddi.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > > b/drivers/gpu/drm/i915/intel_ddi.c > > index 80e96f1..9e9bfbe 100644 > > --- a/drivers/gpu/drm/i915/intel_ddi.c > > +++ b/drivers/gpu/drm/i915/intel_ddi.c > > @@ -596,7 +596,7 @@ static int intel_ddi_hdmi_level(struct > > drm_i915_private *dev_priv, enum port por > > > > hdmi_level = dev_priv- > > >vbt.ddi_port_info[port].hdmi_level_shift; > > > > - if (IS_GEN9_LP(dev_priv)) > > + if (IS_GEN9_LP(dev_priv) || INTEL_GEN(dev_priv) >= 10) > Can we assume that this holds always for GEN10 and above platforms? Hi Mika, thanks for looking, but please ignore this patch here. I should have told earlier, sorry, but this patch should be replaced by: https://patchwork.freedesktop.org/series/28883/ reviews and suggestions there are welcome... Thanks, Rodrigo. > > > return hdmi_level; > > > > if (IS_GEN9_BC(dev_priv)) { > > @@ -688,7 +688,7 @@ static void intel_prepare_dp_ddi_buffers(struct > > intel_encoder *encoder) > > enum port port = intel_ddi_get_encoder_port(encoder); > > const struct ddi_buf_trans *ddi_translations; > > > > - if (IS_GEN9_LP(dev_priv)) > > + if (IS_GEN9_LP(dev_priv) || INTEL_GEN(dev_priv) >= 10) > > return; > > > > switch (encoder->type) { > > @@ -741,7 +741,7 @@ static void intel_prepare_hdmi_ddi_buffers(struct > > intel_encoder *encoder) > > enum port port = intel_ddi_get_encoder_port(encoder); > > const struct ddi_buf_trans *ddi_translations_hdmi; > > > > - if (IS_GEN9_LP(dev_priv)) > > + if (IS_GEN9_LP(dev_priv) || INTEL_GEN(dev_priv) >= 10) > > return; > > > > hdmi_level = intel_ddi_hdmi_level(dev_priv, port); _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
