Quoting Joonas Lahtinen (2017-08-15 15:56:07) > On Sat, 2017-08-12 at 12:51 +0100, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c > > index b0738d2b2a7f..874562bd59ae 100644 > > --- a/drivers/gpu/drm/i915/intel_lrc.c > > +++ b/drivers/gpu/drm/i915/intel_lrc.c > > @@ -866,6 +866,7 @@ execlists_context_pin(struct intel_engine_cs *engine, > > i915_ggtt_offset(ce->ring->vma); > > > > ce->state->obj->mm.dirty = true; > > + ce->state->obj->pin_display++; > > This should be closer to intel_ring_pin (my preference). > > > > > i915_gem_context_get(ctx); > > out: > > @@ -892,6 +893,7 @@ static void execlists_context_unpin(struct intel_engine_cs *engine, > > return; > > > > intel_ring_unpin(ce->ring); > > + ce->state->obj->pin_display--; > > Or this should be closer to i915_gem_context_put. Just make it > symmetric. Ah, I see how that would add confusion. Gotcha. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
