Re: [PATCH] drm/i915: Disconnect 32 and 48 bit ppGTT support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017.08.14 20:34:48 +0800, Zhi Wang wrote:
> Looks has_full_48bit_ppgtt is tied to has_full_ppgtt now. Will that be
> disconnected also in future?
>

That's what this is for. So for gvt, we just set has_full_48bit_ppgtt but
not has_full_ppgtt.

> On 08/11/17 17:51, Joonas Lahtinen wrote:
> > Configurations like virtualized environments may support only 48 bit
> > ppGTT without supporting 32 bit ppGTT. Support this by disconnecting
> > the relationship of the two feature bits.
> > 
> > Cc: Tina Zhang <tina.zhang@xxxxxxxxx>
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Zhi Wang <zhi.a.wang@xxxxxxxxx>
> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/i915/i915_gem_gtt.c | 13 +++++++++----
> >   1 file changed, 9 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > index 10aa776..a5eada1 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -180,10 +180,15 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
> >   		return 0;
> >   	}
> > -	if (INTEL_GEN(dev_priv) >= 8 && i915.enable_execlists && has_full_ppgtt)
> > -		return has_full_48bit_ppgtt ? 3 : 2;
> > -	else
> > -		return has_aliasing_ppgtt ? 1 : 0;
> > +	if (INTEL_GEN(dev_priv) >= 8 && i915.enable_execlists) {
> > +		if (has_full_48bit_ppgtt)
> > +			return 3;
> > +
> > +		if (has_full_ppgtt)
> > +			return 2;
> > +	}
> > +
> > +	return has_aliasing_ppgtt ? 1 : 0;
> >   }
> >   static int ppgtt_bind_vma(struct i915_vma *vma,
> > 
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 -
> 4 Domiciled in Helsinki
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux