Re: [maintainer-tools PATCH 4/4] dim: fix list-aliases to not include itself

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 11, 2017 at 06:03:25PM +0300, Jani Nikula wrote:
> dim list-aliases lists "list-aliases" as being an alias of
> "list-aliases". This is because the temporary subcmd variable reference
> is erroneously included in the list. Unset it.

I got confused with to many list-aliases list-aliases, so I run dim list-aliases
and understood what you meant... ;)


Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

> 
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
>  dim | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/dim b/dim
> index d9820ac87358..011cedbd3b6a 100755
> --- a/dim
> +++ b/dim
> @@ -2053,4 +2053,7 @@ if ! declare -f $subcmd_func >/dev/null; then
>  	exit 1
>  fi
>  
> +# throw away to not confuse list-aliases
> +unset subcmd
> +
>  $subcmd_func "$@"
> -- 
> 2.11.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux