Re: [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Aug 9, 2017, at 8:20 PM, Dhinakaran Pandiyan <dhnkrn@xxxxxxxxx> wrote:
> 
> We currently assume port A is connected to a DP sink when VBT is absent,
> instead assume it is connected to an eDP sink, which seems like a more
> common configuration. Although I don't have data to back this up,
> it is still just as valid as asumming port A is not eDP.

I also don't have enough data, but it is the most common configuration on the rvp boards that I see around...
Also the missing vbt case is more for dev platforms anyways right?!


> This reverts to
> the behavior before a98d9c1 ("drm/i915/ddi: Rely on VBT DDI port info for
> eDP detection") except only when there is no VBT. Knowing whether a panel
> is eDP or not from the panel itself would have been nicer, but I cannot
> find any DPCD registers that provide this reliably.
> 
> Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
> Cc: Imre Deak <imre.deak@xxxxxxxxx>
> Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> Cc: Clint Taylor <clinton.a.taylor@xxxxxxxxx>

+Joe
Does this fix the issue Joe has on his GLK B0?

> 
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_bios.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 82b144c..89a405e 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1403,6 +1403,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
>        info->supports_dvi = (port != PORT_A && port != PORT_E);
>        info->supports_hdmi = info->supports_dvi;
>        info->supports_dp = (port != PORT_E);
> +        info->supports_edp = (port == PORT_A);

>    }
> }
> 
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux