Re: [PATCH i-g-t] tests/kms: increase max threshold time for edid read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Clinton!

If you add:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100047

You have my Rb.
/Marta

> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf
> Of clinton.a.taylor@xxxxxxxxx
> Sent: Friday, August 4, 2017 9:23 PM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject:  [PATCH i-g-t] tests/kms: increase max threshold time for
> edid read
> 
> From: Clint Taylor <clinton.a.taylor@xxxxxxxxx>
> 
> Current 50ms max threshold timing for an EDID read is very close to the
> actual time for a 2 block HDMI EDID read of 48ms. Any delay like a clock
> stretch by the EDID eeprom will cause this test to fail. A 4 block HDMI EDID
> read takes approximately 88ms under nominal conditions, making the max
> threshold 95ms will allow this test to pass regardless of monitor attached.
> 
> Signed-off-by: Clint Taylor <clinton.a.taylor@xxxxxxxxx>
> ---
>  tests/kms_sysfs_edid_timing.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 1201388..b45e080 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -27,14 +27,14 @@
>  #include <sys/stat.h>
> 
>  #define THRESHOLD_PER_CONNECTOR	10
> -#define THRESHOLD_TOTAL		50
> +#define THRESHOLD_TOTAL		95
>  #define CHECK_TIMES		15
> 
>  IGT_TEST_DESCRIPTION("This check the time we take to read the content of
> all "
>  		     "the possible connectors. Without the edid -
> ENXIO patch "
> 
> "(http://permalink.gmane.org/gmane.comp.video.dri.devel/62083), "
> -		     "we sometimes take a *really* long time. "
> -		     "So let's just check for some reasonable
> timing here");
> +		     "we sometimes take a *really* long time. So
> let's just "
> +		     "check an approximate HDMI 4 block edid
> read timing here");
> 
> 
>  igt_simple_main
> --
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux