Re: [PATCH igt 05/10] igt/drv_hangman: Skip if resets are disallowed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Michał Winiarski (2017-07-28 14:53:40)
> On Fri, Jul 28, 2017 at 01:08:03PM +0100, Chris Wilson wrote:
> > If we tell the machine to reset but they are disallowed, we will leave
> > the system in a wedged state, preventing the majority of subsequent
> > tests.
> > ---
> >  tests/drv_hangman.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> Missed sign-off.
> 
> > 
> > diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
> > index 0551ec16..de57e128 100644
> > --- a/tests/drv_hangman.c
> > +++ b/tests/drv_hangman.c
> > @@ -30,6 +30,7 @@
> >  #include <limits.h>
> >  #include <sys/types.h>
> >  #include <sys/stat.h>
> > +#include <sys/ioctl.h>
> >  #include <fcntl.h>
> >  
> >  #include "igt_sysfs.h"
> > @@ -239,7 +240,9 @@ igt_main
> >               int idx;
> >  
> >               device = drm_open_driver(DRIVER_INTEL);
> > +             igt_allow_hang(device, 0, 0);
> 
> Umm... That's not skipping.
> That's enabling reset, right?

It's a skip if we cannot reset either due to env flags or lack of kernel
support for reset. We are simply asking if this test group is allowed to
reset.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux