> -----Original Message----- > From: Ville Syrjälä [mailto:ville.syrjala@xxxxxxxxxxxxxxx] > Sent: Tuesday, July 11, 2017 9:42 PM > To: Srinivas, Vidya <vidya.srinivas@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 7/8] drm/i915: Add NV12 as supported > format for sprite plane > > On Tue, Jul 11, 2017 at 07:40:55PM +0530, Vidya Srinivas wrote: > > From: Chandra Konduru <chandra.konduru@xxxxxxxxx> > > > > This patch adds NV12 to list of supported formats for sprite plane. > > > > v2: Rebased (me) > > > > v3: Review comments by Ville addressed > > - Removed skl_plane_formats_with_nv12 and added > > NV12 case in existing skl_plane_formats > > - Added the 10bpc RGB formats > > > > v4: Addressed review comments from Clinton A Taylor > > "Why are we adding 10 bit RGB formats with the NV12 series > patches? > > Trying to set XR30 or AB30 results in error returned even though > > the modes are advertised for the planes" > > - Removed 10bit RGB formats added previously with NV12 series > > > > v5: Missed the Tested-by/Reviewed-by in the previous series > > Adding the same to commit message in this version. > > Addressed review comments from Clinton A Taylor > > "Why are we adding 10 bit RGB formats with the NV12 series > patches? > > Trying to set XR30 or AB30 results in error returned even though > > the modes are advertised for the planes" > > - Previous version has 10bit RGB format removed from VLV formats > > by mistake. Fixing that in this version. > > Removed 10bit RGB formats added previously with NV12 series > > for SKL. > > > > Tested-by: Clinton Taylor <clinton.a.taylor@xxxxxxxxx> > > Reviewed-by: Clinton Taylor <clinton.a.taylor@xxxxxxxxx> > > Signed-off-by: Chandra Konduru <chandra.konduru@xxxxxxxxx> > > Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@xxxxxxxxx> > > Signed-off-by: Vidya Srinivas <vidya.srinivas@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/intel_sprite.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_sprite.c > > b/drivers/gpu/drm/i915/intel_sprite.c > > index 9a6b011..f1d65d9 100644 > > --- a/drivers/gpu/drm/i915/intel_sprite.c > > +++ b/drivers/gpu/drm/i915/intel_sprite.c > > @@ -1078,6 +1078,7 @@ int intel_sprite_set_colorkey(struct drm_device > *dev, void *data, > > DRM_FORMAT_YVYU, > > DRM_FORMAT_UYVY, > > DRM_FORMAT_VYUY, > > + DRM_FORMAT_NV12, > > }; > > That's not correct for pipe C sprites on SKL/KBL/BXT. > > Also like I mentioned earlier at least SKL shouldn't be advertizing NV12 at > all. IIRC you were going to find out what the situation is with the other > platforms. > I checked for the platform support we need. For now, we wanted to enable it on Apollo Lake platforms (BXT).I have changed the patch and addressed the review comments. Kindly have a check. Thank you. Regards Vidya > > > > struct intel_plane * > > -- > > 1.9.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Ville Syrjälä > Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
