On 2017.07.17 01:10:03 +0000, Zhang, Tina wrote:
> > > +struct vfio_device_gfx_plane_info {
> > > + __u32 argsz;
> > > + __u32 flags;
> > > + /* in */
> > > + __u32 drm_plane_type; /* type of plane:
> > > DRM_PLANE_TYPE_* */
> > > + /* out */
> > > + __u32 drm_format; /* drm format of plane */
> >
> > DRM_FORMAT_*
> >
> > drm_format_mod is gone? Not needed?
> > How tiled buffers are handled then?
> Drm_format_mod is used as one of the plane's characteristics when judging the dma-buf of the plane is new to expose or an old exposed one. As from V10 we leave this comparing logic to kernel, user mode might not need this field any more. If user mode wants, this can be also got though drm APIs. For example, eglCreateImageKHR() uses drm APIs to get the tiling format, without asking the invoker to explicitly use it as a parameter.
> Do you think this field is still needed?
>
Of course we need that modifier for complete format info. Don't just
think for i915 usage, there's possible modifier for other vendor
driver, and it's required for e.g ADDFB2 in drm kms. Pls add it back
in next version.
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
