Re: [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/13/2017 6:56 PM, Ville Syrjälä wrote:

We don't want breaks in the loop. It's meant to go through all the
connectors for the crtc. Granted on modern platforms there can only be
one, but IMO assuming that just makes the whole thing look confusing.
It's much clearer IMO if we do

if (420) {
	check 420 dc modes;
} else {
	check 444 dc modes;
}
I dint want to add another loop for the 420 stuff, hence was reusing the existing loop.
Now, my steps were:
- If there is a CRTC match, I got the right CRTC.
- On this CRTC, if YCBCR420 output is enabled, I should just check DRM_EDID_YCBCR420_DC_36 for 420_12BPC, so if it supports DRM_EDID_YCBCR420_DC_36 say yes, else no. - But I also want to go through the WAR condition below, added for GLK. So I can't return from here.

Do you prefer me adding another loop just for YCBCR420 ?

- Shashank
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux