Quoting Mahesh Kumar (2017-07-13 11:39:02) > +void intel_enable_ipc(struct drm_i915_private *dev_priv) > +{ > + u32 val; > + > + val = I915_READ(DISP_ARB_CTL2); > + > + if (dev_priv->ipc_enabled) > + val |= DISP_IPC_ENABLE; > + else > + val &= ~DISP_IPC_ENABLE; > + > + I915_WRITE(DISP_ARB_CTL2, val); > +} > + > +void intel_init_ipc(struct drm_i915_private *dev_priv) > +{ > + dev_priv->ipc_enabled = false; > + if (INTEL_GEN(dev_priv) < 9 || IS_SKYLAKE(dev_priv)) > + return; So dev_priv->ipc_enabled is just a dev_priv->info.has_ipc, its state never changes at runtime? Using a intel_device_info field then has a few useful side-effects including automatic printing in the lists of capabilities. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx