On Fri, Mar 17, 2017 at 12:15 PM, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> wrote: > On to, 2017-03-16 at 13:20 +0000, Chris Wilson wrote: >> Currently, the last object in the execlist is the always the batch. >> However, when building the batch buffer we often know the batch object >> first and if we can use the first slot in the execlist we can emit >> relocation instructions relative to it immediately and avoid a separate >> pass to adjust the relocations to point to the last execlist slot. >> >> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> This patch was reviewed/pushed full month before the mesa patch was fully reviewed and ready for merging. That's not how uapi is done. I've fixed this up now by at least reviewing the mesa patch, but for next time around: If you review uapi, and you don't make sure the userspace side is in good shape too, then you've not reviewed the patch properly. Same goes for reviewing and not making sure there's tests, but that's another rant. Ken, pls make sure we don't end up with another case like resource streamer (or tell me I should revert this). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
