On Tue, Jul 4, 2017 at 5:28 PM, Takashi Iwai <tiwai@xxxxxxx> wrote: > On Tue, 04 Jul 2017 17:14:39 +0200, > Daniel Vetter wrote: >> On Thu, Jun 29, 2017 at 12:25 PM, Daniel Vetter <daniel@xxxxxxxx> wrote: >> >> Now I took a closer look, and this appears rather like a brown paper >> >> bag bug, not about the deferred probe or module dependency. >> >> The fix patch is below. Could you check whether it works? >> > >> > Yay, this works! >> > >> > Tested-by: Daniel Vetter <daniel.vetter@xxxxxxxx> >> >> Next one: i915 module reloading is broken because something is holding >> onto a module reference and doesn't drop it. Didn't check which sets >> of patches introduced this, but iirc this worked last week. Disabling >> hda-intel gets in Kconfig gets rid of the problem, so I assume >> something in the sound driver is leaking that reference ... >> >> It's also causing lots and lots of red in our CI :( If we can't fix >> this we need to disable snd-hda-intel there too. > > I spotted out a typo in my previous patch that leads to the module > reference unbalance. The fix is already in sound.git tree today: > https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?h=for-linus&id=fc18282cdcba984ab89c74d7e844c10114ae0795 > > The bug was introduced after 4.12. Ok, CI over here confirmed that it's all good again. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
