Re: [RFC i-g-t 1/2] extended.testlist: Remove default and render engine test duplicates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 16, 2017 at 12:55 PM, Tvrtko Ursulin <tursulin@xxxxxxxxxxx> wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
>
> Where there is both default and render for the same test,
> remove the former to save some execution time.

If they are redundant, why do we even have them? Can we just remove
the testcase itself? Accumulating unused tests of questionable use at
best in igt is serious pain, because it means we never can get to a
world where new testcases are auto-added to CI withou some manual
review. And that's the world of pain we live in now and I really want
to get out of it. That means reviewing and removing testcases, not
massaging courated testlists forever, I don't think we have the time
for that among all the other tasks.

</rant> :-)

Cheers, Daniel
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> ---
>  tests/intel-ci/extended.testlist | 21 ---------------------
>  1 file changed, 21 deletions(-)
>
> diff --git a/tests/intel-ci/extended.testlist b/tests/intel-ci/extended.testlist
> index 24ec295faf66..e0926ff09bcd 100644
> --- a/tests/intel-ci/extended.testlist
> +++ b/tests/intel-ci/extended.testlist
> @@ -76,7 +76,6 @@ igt@gem_ringfill@blt-bomb
>  igt@gem_ringfill@bsd-bomb
>  igt@gem_ringfill@bsd1-bomb
>  igt@gem_ringfill@bsd2-bomb
> -igt@gem_ringfill@default-bomb
>  igt@gem_ringfill@render-bomb
>  igt@gem_ringfill@vebox-bomb
>  igt@gem_userptr_blits@stress-mm
> @@ -1154,12 +1153,10 @@ igt@gem_bad_reloc@negative-reloc-bltcopy
>  igt@gem_bad_reloc@negative-reloc-bsd
>  igt@gem_bad_reloc@negative-reloc-bsd1
>  igt@gem_bad_reloc@negative-reloc-bsd2
> -igt@gem_bad_reloc@negative-reloc-default
>  igt@gem_bad_reloc@negative-reloc-lut-blt
>  igt@gem_bad_reloc@negative-reloc-lut-bsd
>  igt@gem_bad_reloc@negative-reloc-lut-bsd1
>  igt@gem_bad_reloc@negative-reloc-lut-bsd2
> -igt@gem_bad_reloc@negative-reloc-lut-default
>  igt@gem_bad_reloc@negative-reloc-lut-render
>  igt@gem_bad_reloc@negative-reloc-lut-vebox
>  igt@gem_bad_reloc@negative-reloc-render
> @@ -1203,7 +1200,6 @@ igt@gem_cs_prefetch@blt
>  igt@gem_cs_prefetch@bsd
>  igt@gem_cs_prefetch@bsd1
>  igt@gem_cs_prefetch@bsd2
> -igt@gem_cs_prefetch@default
>  igt@gem_cs_prefetch@render
>  igt@gem_cs_prefetch@vebox
>  igt@gem_cs_tlb@blt
> @@ -1220,7 +1216,6 @@ igt@gem_ctx_bad_exec@blt
>  igt@gem_ctx_bad_exec@bsd
>  igt@gem_ctx_bad_exec@bsd1
>  igt@gem_ctx_bad_exec@bsd2
> -igt@gem_ctx_bad_exec@default
>  igt@gem_ctx_bad_exec@render
>  igt@gem_ctx_bad_exec@vebox
>  igt@gem_ctx_exec@lrc-lite-restore
> @@ -1244,7 +1239,6 @@ igt@gem_ctx_switch@bsd1
>  igt@gem_ctx_switch@bsd1-interruptible
>  igt@gem_ctx_switch@bsd2
>  igt@gem_ctx_switch@bsd2-interruptible
> -igt@gem_ctx_switch@default-interruptible
>  igt@gem_ctx_switch@render
>  igt@gem_ctx_switch@render-interruptible
>  igt@gem_ctx_switch@vebox
> @@ -1322,7 +1316,6 @@ igt@gem_exec_nop@blt
>  igt@gem_exec_nop@bsd
>  igt@gem_exec_nop@bsd1
>  igt@gem_exec_nop@bsd2
> -igt@gem_exec_nop@default
>  igt@gem_exec_nop@parallel
>  igt@gem_exec_nop@render
>  igt@gem_exec_nop@series
> @@ -1340,9 +1333,6 @@ igt@gem_exec_parallel@bsd2
>  igt@gem_exec_parallel@bsd2-contexts
>  igt@gem_exec_parallel@bsd2-fds
>  igt@gem_exec_parallel@contexts
> -igt@gem_exec_parallel@default
> -igt@gem_exec_parallel@default-contexts
> -igt@gem_exec_parallel@default-fds
>  igt@gem_exec_parallel@fds
>  igt@gem_exec_parallel@render
>  igt@gem_exec_parallel@render-contexts
> @@ -1392,7 +1382,6 @@ igt@gem_exec_reloc@active-blt
>  igt@gem_exec_reloc@active-bsd
>  igt@gem_exec_reloc@active-bsd1
>  igt@gem_exec_reloc@active-bsd2
> -igt@gem_exec_reloc@active-default
>  igt@gem_exec_reloc@active-render
>  igt@gem_exec_reloc@active-vebox
>  igt@gem_exec_schedule@deep-blt
> @@ -1431,7 +1420,6 @@ igt@gem_exec_whisper@bsd1-normal
>  igt@gem_exec_whisper@bsd2-normal
>  igt@gem_exec_whisper@chain
>  igt@gem_exec_whisper@contexts
> -igt@gem_exec_whisper@default-normal
>  igt@gem_exec_whisper@fds
>  igt@gem_exec_whisper@forked
>  igt@gem_exec_whisper@interruptible
> @@ -1682,8 +1670,6 @@ igt@gem_ringfill@bsd2
>  igt@gem_ringfill@bsd2-child
>  igt@gem_ringfill@bsd2-interruptible
>  igt@gem_ringfill@bsd2-s3
> -igt@gem_ringfill@default-child
> -igt@gem_ringfill@default-s3
>  igt@gem_ringfill@render
>  igt@gem_ringfill@render-child
>  igt@gem_ringfill@render-interruptible
> @@ -1728,26 +1714,22 @@ igt@gem_storedw_loop@long-blt
>  igt@gem_storedw_loop@long-bsd
>  igt@gem_storedw_loop@long-bsd1
>  igt@gem_storedw_loop@long-bsd2
> -igt@gem_storedw_loop@long-default
>  igt@gem_storedw_loop@long-render
>  igt@gem_storedw_loop@long-vebox
>  igt@gem_storedw_loop@short-blt
>  igt@gem_storedw_loop@short-bsd
>  igt@gem_storedw_loop@short-bsd1
>  igt@gem_storedw_loop@short-bsd2
> -igt@gem_storedw_loop@short-default
>  igt@gem_storedw_loop@short-render
>  igt@gem_storedw_loop@short-vebox
>  igt@gem_sync@blt
>  igt@gem_sync@bsd
>  igt@gem_sync@bsd1
>  igt@gem_sync@bsd2
> -igt@gem_sync@default
>  igt@gem_sync@many-blt
>  igt@gem_sync@many-bsd
>  igt@gem_sync@many-bsd1
>  igt@gem_sync@many-bsd2
> -igt@gem_sync@many-default
>  igt@gem_sync@many-render
>  igt@gem_sync@many-vebox
>  igt@gem_sync@render
> @@ -1755,7 +1737,6 @@ igt@gem_sync@store-blt
>  igt@gem_sync@store-bsd
>  igt@gem_sync@store-bsd1
>  igt@gem_sync@store-bsd2
> -igt@gem_sync@store-default
>  igt@gem_sync@store-render
>  igt@gem_sync@store-vebox
>  igt@gem_sync@vebox
> @@ -1808,7 +1789,6 @@ igt@gem_wait@busy-blt
>  igt@gem_wait@busy-bsd
>  igt@gem_wait@busy-bsd1
>  igt@gem_wait@busy-bsd2
> -igt@gem_wait@busy-default
>  igt@gem_wait@busy-render
>  igt@gem_wait@busy-vebox
>  igt@gem_wait@invalid-buf
> @@ -1817,7 +1797,6 @@ igt@gem_wait@wait-blt
>  igt@gem_wait@wait-bsd
>  igt@gem_wait@wait-bsd1
>  igt@gem_wait@wait-bsd2
> -igt@gem_wait@wait-default
>  igt@gem_wait@wait-render
>  igt@gem_wait@wait-vebox
>  igt@gem_workarounds@reset
> --
> 2.9.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux