On Tue, Jun 20, 2017 at 05:46:03PM +0000, Pandiyan, Dhinakaran wrote: > > > > On Tue, 2017-06-20 at 11:03 +0200, Daniel Vetter wrote: > > On Mon, Jun 05, 2017 at 02:56:04PM -0700, Puthikorn Voravootivat wrote: > > > This patch set contain 3 patches which are already reviewed by DK. > > > Another 6 patches in previous version was already merged in v7 and v9. > > > - First patch sets the PWM freqency to match data in panel vbt. > > > - Next patch adds heuristic to determine whether we should use AUX > > > or PWM pin to adjust panel backlight brightness. > > > - Last patch adds support for dynamic brightness. > > > > > > Change log: > > > v11: > > > - Reorder patches in v10 to make the last patch come first > > > - Fix nits > > > > > > v10: > > > - Add heuristic in patch #1 > > > - Add _unsafe mod option in patch #1, #2 > > > - handle frequency set error in patch #3 > > > > > > v9: > > > - Fix nits in v8 > > > > > > v8: > > > - Drop 4 patches that was already merged > > > - Move DP_EDP_BACKLIGHT_AUX_ENABLE_CAP check to patch #2 to avoid > > > behavior change if only apply patch #1 > > > - Add TODO to warn about enable backlight twice in patch #2 > > > - Use DIV_ROUND_CLOSEST instead of just "/" in patch #5 > > > - Fix bug calculate pn in patch #5 > > > - Clarify commit message / code comment in patch #5 > > > > > > v7: > > > - Add check in intel_dp_pwm_pin_display_control_capable in patch #4 > > > - Add option in patch #6 to enable DPCD or not > > > - Change definition in patch #8 and implementation in #9 to use Khz > > > - Fix compiler warning from build bot in patch #9 > > > > > > v6: > > > - Address review from Dhinakaran > > > - Make PWM frequency to have highest value of Pn that make the > > > frequency still within 25% of desired frequency. > > > > > > v5: > > > - Split first patch in v4 to 3 patches > > > - Bump priority for "Correctly enable backlight brightness adjustment via DPCD" > > > - Make logic clearer for the case that both PWM pin and AUX are supported > > > - Add more log when write to register fail > > > - Add log when enable DBC > > > > > > v4: > > > - Rebase / minor typo fix. > > > > > > v3: > > > - Add new implementation of PWM frequency patch > > > > > > v2: > > > - Drop PWM frequency patch > > > - Address suggestion from Jani Nikula > > > > > > Puthikorn Voravootivat (3): > > > drm/i915: Set PWM divider to match desired frequency in vbt > > > drm/i915: Add heuristic to determine better way to adjust brightness > > > drm/i915: Add option to support dynamic backlight via DPCD > > > > Random unrelated observation, but shouldn't we have the dp aux backlight > > driver as a generic helper in the drm core dp helper library? Doing sink > > logic like this in drivers is kinda wrong ... > > -Daniel > > > We could definitely move some of the stuff to the core helpers. There is > also a bit of follow-up work needed to optimize DPCD read/writes. They > can be done together after this. > > I don't know if you had a chance to look at this series in detail. But > if you did, do you see any blockers for accepting this series? No, my comment was really just a quick observation. Follow-up for that is perfectly fine. I didn't look at the patches in detail. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
