On Fri, Jun 09, 2017 at 10:54:13AM -0700, Michel Thierry wrote:
> On 6/9/2017 10:02 AM, Antonio Argenziano wrote:
> > Test expects pending batches to be discarded after a reset. That is no
> > longer the case. Fixed to expect a normal execution.
>
> You could expand this to say:
> after commit 821ed7df6e2a ("drm/i915: Update reset path to fix incomplete
> requests"), that is no longer the case.
>
> >
> > Cc: Michel Thierry <michel.thierry@xxxxxxxxx>
> >
> > Signed-off-by: Antonio Argenziano <antonio.argenziano@xxxxxxxxx>
>
> If we want the test to pass, then it's ok. Someone else may say we need
> further subtests.
>
> On the basis this brings existing tests to the current expectation,
> Reviewed-by: Michel Thierry <michel.thierry@xxxxxxxxx>
>
> (with the updated commit msg).
>
> -Michel
Hey,
What is the plan regarding this patch? It has been stale for a while.
We can push it with the updated commit message if Antonio is okay with
the change.
On conditional reviews, it is a good practice, if the original author
follows up with the "fixed" commit as a reply or gives us assent on IRC
to do the change on our side.
Also, from CONTRIBUTING:
-----------------------------------------------------------------------------
Please use --subject-prefix="PATCH i-g-t" so that i-g-t patches are easily
identified in the massive amount mails on intel-gfx. To ensure this is always
done, autogen.sh will run:
git config format.subjectprefix "PATCH i-g-t"
on its first invocation.
-----------------------------------------------------------------------------
Lack of proper prefix breaks filtering / patchwork and makes changes
harder to track.
The autogen.sh thing is a recent addition.
Thanks!
--
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
