Re: [PATCH v9 05/21] drm/i915: Add support for per engine reset recovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/06/17 05:46, Chris Wilson wrote:
Quoting Michel Thierry (2017-06-15 21:18:12)
@@ -2992,10 +3014,8 @@ void i915_gem_reset_finish(struct drm_i915_private *dev_priv)

        lockdep_assert_held(&dev_priv->drm.struct_mutex);

-       for_each_engine(engine, dev_priv, id) {
-               tasklet_enable(&engine->irq_tasklet);
-               kthread_unpark(engine->breadcrumbs.signaler);
-       }
+       for_each_engine(engine, dev_priv, id)
+               i915_gem_reset_finish_engine(engine);

And we shouldn't forget to clear the active_request here!

The hangcheck.active_request?

And thanks for spotting the break/continue error.

-Michel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux