Re: [i-g-t PATCH v4 2/2] Convert tools shell tests to C version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 14, 2017 at 01:06:45PM +0300, Abdiel Janulgue wrote:
> v4: Go thru /dev/kmsg instead of doing "dmesg | grep ..." (Arek).
>     Split conversion to couple of patches.
> 
> Converted:
>      - sysfs_l3_parity
>      - test_rte_check  (same as check_drm_clients)
>      - tools_test
>      - ZZ_check_dmesg
> 
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@xxxxxxxxxxxxxxx>
> Cc: Cc: Arkadiusz Hiler <arkadiusz.hiler@xxxxxxxxx>
> ---
>  tests/Makefile.sources  |   8 +--
>  tests/ZZ_check_dmesg    |  11 ----
>  tests/check_drm_clients |   6 --
>  tests/sysfs_l3_parity   |  22 --------
>  tests/test_rte_check    |   6 --
>  tests/tools_test        |  16 ------
>  tests/tools_test.c      | 146 ++++++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 147 insertions(+), 68 deletions(-)
>  delete mode 100755 tests/ZZ_check_dmesg
>  delete mode 100755 tests/check_drm_clients
>  delete mode 100755 tests/sysfs_l3_parity
>  delete mode 100755 tests/test_rte_check
>  delete mode 100755 tests/tools_test
>  create mode 100644 tests/tools_test.c
> 
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index c40b2ab..b0b2f22 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -232,18 +232,13 @@ TESTS_progs = \
>  	vgem_basic \
>  	vgem_slow \
>  	debugfs_test \
> +	tools_test \

Now I've noticed: please stick to alphabetic ordering. That includes
previous patch :-P

With that:
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@xxxxxxxxx>

>  	$(NULL)
>  
>  TESTS_progs_X = \
>      gem_concurrent_all \
>      $(NULL)
>  
> -TESTS_scripts = \
> -	sysfs_l3_parity \
> -	test_rte_check \
> -	tools_test \
> -	$(NULL)
> -
>  kernel_tests = \
>  	$(TESTS_progs) \
>  	$(TESTS_scripts) \
> @@ -273,7 +268,6 @@ HANG = \
>  	$(NULL)
>  
>  scripts = \
> -	check_drm_clients \
>  	ddx_intel_after_fbdev \
>  	drm_lib.sh \
>  	drm_getopt.sh \
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux