Op 12-06-17 om 14:48 schreef Ville Syrjälä: > On Mon, Jun 12, 2017 at 12:21:15PM +0200, Maarten Lankhorst wrote: >> Pass crtc_state to the enable callback, and connector_state to all callbacks. >> This will eliminate the need to guess for the correct pipe in these >> callbacks. >> >> The crtc state is required for pch_enable_backlight to obtain the correct >> cpu_transcoder. >> >> intel_dp_aux_backlight's setup function is called before hw readout, so >> crtc_state and connector_state->best_encoder are NULL in the enable() >> and set() callbacks. > This looks like a bug in the code. Massaging the backlight during setup > doesn't seem like the right thing to do. It should read the current > state instead of modifying it. So this is something that the relevant > people should take a look at. Cc:ing some people... > > Anyways, the series looks good to me, so > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Thanks, trybot seems to test backlight too (pm_backlight). No errors caught there so pushed. :) I think you've forgot to attach some some people to cc, I only see the ml. ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
